feat(decider): make the platform production-ready beyond its first consumer#486
Merged
Conversation
yordis
commented
Jul 17, 2026
yordis
commented
Member
- A verified audit confirmed the decider platform pays O(whole-stream) replay I/O, runs blind (four log lines of telemetry total), cannot recover from a bad snapshot, and forces every consumer to re-build read-side plumbing the scheduler already hand-rolled once; those costs compound with each new decider-based service, so they are closed now, before more consumers land.
- Capability questions that need owner sign-off rather than platform defaults (authorization, multi-tenancy, admission control, retention) are recorded as draft ADRs instead of code.
- The per-variant wire error-code hook is dropped because freezing wire contract values is an owner decision, and an unused hook invites accidental contracts.
- Review feedback is folded in: workflow files and mise config stay declarative with scripts behind mise tasks, and conformance suites stay human-readable.
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
… and retention directions Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…d-trips assertable in TestCase Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…g contract review Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…drain pending snapshot writes Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…transient broker failures Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…nd a hardened host sandbox Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…s, and enforce strict conformance Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…essing primitives Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…cenario definition Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…cation Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…cumented API surface Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…sed status Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryMedium Risk Overview Conformance and guest bridge: NATS adapter: Adds reusable Docs: New Reviewed by Cursor Bugbot for commit 179150b. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Important Review skippedToo many files! This PR contains 123 files, which is 23 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (125)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3518d32. Configure here.
…rm-improvements Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com> # Conflicts: # docs/adr/index.md
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
|
Code Coverage SummaryDetailsDiff against mainResults for commit: 179150b Minimum allowed coverage is ♻️ This comment has been updated with latest results |
yordis
added
the
rust:coverage-baseline-reset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.