chore(agents): make model selection ownership explicit - #515
Merged
Conversation
The shipped contract and the draft definition ADRs disagreed about who owns model selection, so an implementer reading either one alone would reach the wrong conclusion about whether the platform can read a pinned model. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryLow Risk Overview ADRs #25, #31, and #32 gain explicit consequences and caveats that draft text describing platform-owned model pins is intended design whose precondition is unmet; ADR#0032 is described as blocked on resolving ownership, not merely unimplemented. The glossary, agent execution index, and agent-platform decision record (Q5/Q16) are updated so
Reviewed by Cursor Bugbot for commit b8ece46. Bugbot is set up for automated code reviews on this repo. Configure here. |
WalkthroughClarifies that model selection, parameters, and dependency declarations belong to runtime-owned ChangesAgent definition ownership
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The glossary and the model-routing ADRs asserted platform-owned model selection as settled fact, so a reader following any of them would build against a field the contract does not carry. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
|
Code Coverage SummaryDetailsDiff against mainResults for commit: b8ece46 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
AgentConfigurationand thesettingscomment clarified here