Skip to content

Accepted the manager's own refusal of a host-held port in the e2e test - #350

Merged
acburdine merged 1 commit into
next-dockerfrom
claude/dazzling-rosalind-2b465c
Oct 8, 2026
Merged

acburdine merged 1 commit into
next-dockerfrom
claude/dazzling-rosalind-2b465c

Conversation

@acburdine

Copy link
Copy Markdown
Member

The manager now asks the host, through host.docker.internal, whether a requested --port is held by a program Docker does not manage, and refuses it before writing anything. On OrbStack and Docker Desktop that refusal comes first, so the "A port held by a program Docker does not manage" step in tests/e2e/install.sh failed on its first check, which expected Docker's bind error.

The step now accepts either refusal:

  • where the manager can see the host's ports (OrbStack, Docker Desktop): already in use on this host by something outside Docker, --port, Nothing has been changed
  • on Linux: Docker's bind error naming 127.0.0.1:<port>, already (in use|allocated), choose another for Ghost with --port, Nothing that was already running was stopped

Both still check that the directory is empty, no containers are left, the holder is alive, and a free --port succeeds. The Linux branch now checks the whole choose another for Ghost with --port phrase; a stray -- argument had made it match any -- in the output.

shellcheck tests/e2e/install.sh passes. The e2e script has not been run on this branch yet.

🤖 Generated with Claude Code

The manager now asks the host, through host.docker.internal, whether a
requested --port is held by a program Docker does not manage, and
refuses it before writing anything. On OrbStack and Docker Desktop that
refusal comes first, so the step expecting Docker's bind error failed
on its first check.

The step now accepts either refusal: the manager's, where it can see
the host's ports, or Docker's bind error on Linux. Both still check
that the directory is empty, no containers are left, the holder is
alive and a free --port succeeds. The Linux branch also checks the
whole "choose another for Ghost with --port" phrase; a stray `--`
argument had made it match any `--` in the output.
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 1e3fc0cb-12a8-47a2-bb01-3b77f1bee2c6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@acburdine
acburdine merged commit fbfcb96 into next-docker Oct 8, 2026
7 checks passed
@acburdine
acburdine deleted the claude/dazzling-rosalind-2b465c branch October 8, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant