Repository navigation
Accepted the manager's own refusal of a host-held port in the e2e test - #350
Merged
Merged
Conversation
The manager now asks the host, through host.docker.internal, whether a requested --port is held by a program Docker does not manage, and refuses it before writing anything. On OrbStack and Docker Desktop that refusal comes first, so the step expecting Docker's bind error failed on its first check. The step now accepts either refusal: the manager's, where it can see the host's ports, or Docker's bind error on Linux. Both still check that the directory is empty, no containers are left, the holder is alive and a free --port succeeds. The Linux branch also checks the whole "choose another for Ghost with --port" phrase; a stray `--` argument had made it match any `--` in the output.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manager now asks the host, through
host.docker.internal, whether a requested--portis held by a program Docker does not manage, and refuses it before writing anything. On OrbStack and Docker Desktop that refusal comes first, so the "A port held by a program Docker does not manage" step intests/e2e/install.shfailed on its first check, which expected Docker's bind error.The step now accepts either refusal:
already in use on this host by something outside Docker,--port,Nothing has been changed127.0.0.1:<port>,already (in use|allocated),choose another for Ghost with --port,Nothing that was already running was stoppedBoth still check that the directory is empty, no containers are left, the holder is alive, and a free
--portsucceeds. The Linux branch now checks the wholechoose another for Ghost with --portphrase; a stray--argument had made it match any--in the output.shellcheck tests/e2e/install.shpasses. The e2e script has not been run on this branch yet.🤖 Generated with Claude Code