Repository navigation
Simplified manager contracts, recovery state and override inventory - #381
Merged
Merged
Conversation
ref https://linear.app/ghost/issue/PLA-511/simplify-and-harden-the-next-docker-manager-following-branch-review The next-docker documentation repeated current contracts alongside completed work and superseded designs. Give operator guidance, architecture and the remaining roadmap distinct homes so maintainers update fewer copies. Derive additional overrides from Compose's ordered file list. This also fixes a nested compose.override.yml being omitted from backups when no root override exists. Preserve the startup boundary that prevents update recovery from overwriting accepted writes. - docs/architecture.md: own current boundaries and recovery invariants. - docs/ghost-cli-replacement.md: retain remaining requirements and gates. - docs/install.md, docs/configuration.md, docs/bundle-v1.md: consolidate operator contracts and remove stale implementation history. - AGENTS.md, README.md, help: route readers to authoritative guidance. - manager/src/compose.ts, resolved.ts, backup.ts, restore.ts: derive one override inventory and avoid repeated state and transformations. - manager/src/commands/self-update.ts: represent the recovery boundary directly and remove unused update context. - manager/test/backup.test.ts, integration/compose.test.ts: verify nested overrides survive backup/restore and merge through real Compose. - manager/test/integration/resolved.test.ts, services.test.ts: remove the duplicated resolved-state fixture field. - manager/src comments and runtime/workflow entry points: link current architecture instead of obsolete plan sections. - .env.example, ghost.env.example, pages/index.html: correct stale usage. - tests/e2e/self-update.sh: describe the existing write-retention checks.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/ghost/issue/PLA-511/simplify-and-harden-the-next-docker-manager-following-branch-review
The documentation mixed current contracts with completed work and superseded designs, while manager code maintained duplicate override inventories and more update stages than recovery needed. This pass consolidates those sources without changing the recovery boundary or supported workflows.
Changes
docs/architecture.md; keep operator usage/recovery in installation docs, configuration contracts in configuration docs, and outstanding requirements in the roadmap. Schemas and file inventories remain authoritative in code.AGENTS.mdto routing, execution constraints and high-value warnings.GD_COMPOSE_OVERRIDES=overrides/compose.override.ymland no root override, the custom file is now captured and restored. Tests cover both root-override states and real Compose merging with relative/absolute paths.Based on
5a392166, the merged result of #380. Its nested-override regression was still present; no follow-up fix was found. Compose ownership, image-only self-update, migration version requirements, exact-version import, native bulk-data tools and remaining roadmap requirements are preserved. No dependencies or compatibility layers were added.Validation
git diff --checkpassed.Further removal of recorded installation metadata would change what
infopromises and needs a product decision; that contract is unchanged.