Fix convex function ignoring given properties #2765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kareemjeiroudi
changed the title
4 tasks
smallsaucepan
requested changes
Dec 14, 2024
Member
smallsaucepan
left a comment
smallsaucepan
left a comment
There was a problem hiding this comment.
Thanks for this @kareemjeiroudi. Just a request for a minor change to test.ts and we should be good to go!
kareemjeiroudi
force-pushed
the
fix/#2762-convex-ignores-properties
branch
from
51adb21 to
e17d2cb
Compare
smallsaucepan
approved these changes
Sep 5, 2025
kareemjeiroudi
force-pushed
the
fix/#2762-convex-ignores-properties
branch
from
e17d2cb to
1454744
Compare
Author
|
I had to rebase on master |
Member
|
Hi @kareemjeiroudi would like to merge this PR but can't bring it up to date with master first. Do you know if you have "Allow edits by maintainers" disabled on your branch / repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Using the
convexfunction to combine a feature collection returns a newly constructed polygon with missing properties. This is crucial if the caller of the function attempts to pass additional properties to the end polygon.PR includes a test to test this scenario and improved typing
Resolve #2762
This change fixes a bug where the convex function ignores given properties. I came across this problem, as I was working on a project for one of our clients