chore(deps): consolidate dependabot bumps (vitest, @types/node, typescript, codeql-action) - #34
Merged
Merged
Conversation
…script, codeql-action Bundles the 4 currently-open dependabot PRs (#30-#33) into one tested change rather than merging them separately: - vitest 4.1.10 -> 4.1.11 - @types/node 25.9.1 -> 26.2.0 - typescript 6.0.3 -> 7.0.2 - github/codeql-action 4.37.4 -> 4.37.8 (workflow-only) The typescript bump (#32) was failing CI (lint + test 22.x) because TS 7 removed the `node10` moduleResolution value outright (TS5108). tsconfig.cjs.json used `"moduleResolution": "node10"` for the CJS build with `"ignoreDeprecations": "6.0"` silencing the prior deprecation warning -- TS7 doesn't accept the ignoreDeprecations escape hatch for a removed option, it's just a hard error now. Switched to `"moduleResolution": "Bundler"`, which is TS's own default for a CommonJS module target when the base config's `module` isn't node16/node18/nodenext (base tsconfig.json uses Node16 for the ESM build), so this restores the previous effective resolution behavior rather than changing it. The other three bumps had no code-visible impact; build, full test suite, and npm audit all pass unchanged. Found and left alone (pre-existing, not caused by this bump, not blocking): dist/cjs/*.js has no dist/cjs/package.json declaring `"type": "commonjs"`, so under the root package.json's `"type": "module"`, a plain `require()` against dist/cjs/index.js fails -- confirmed this reproduces identically on typescript@6.0.3 before this bump. Worth its own fix; not touched here since it's orthogonal to a dependency-version PR.
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the 4 currently-open dependabot PRs into one tested change:
Closes #30, #31, #32, #33.
Why bundle these
#32 (typescript) was failing CI (
lint+test 22.x). Root cause: TS 7 removed thenode10moduleResolution value outright (TS5108).tsconfig.cjs.jsonused"moduleResolution": "node10"for the CJS build, with"ignoreDeprecations": "6.0"silencing the prior deprecation warning — TS7 doesn't accept that escape hatch for an option it removed entirely, it's just a hard error now.Fixed by switching to
"moduleResolution": "Bundler"— TS's own default for a CommonJS module target when the base config'smoduleisn'tnode16/node18/nodenext(tsconfig.jsonusesNode16for the ESM build). This restores the previous effective resolution behavior rather than changing it; not a functional change to the emitted output.The other three bumps had no code-visible impact.
Found and deliberately not touched here
dist/cjs/*.jshas nodist/cjs/package.jsondeclaring"type": "commonjs", so under the rootpackage.json's"type": "module", a plainrequire()againstdist/cjs/index.jsfails at runtime. Confirmed this reproduces identically ontypescript@6.0.3before this bump — pre-existing, not something this PR causes or is blocked by. Worth its own fix since it means the CJS build is currently unusable viarequire(), but orthogonal to a dependency-version bump; flagging separately.Test plan
npm run buildclean (both ESM and CJS tsc passes)npm test— 77/77 passingnpm audit --omit=dev— 0 vulnerabilities