feat(TU-34343): Create new AWS Deploy workflow#726
Merged
tom-ridsdale merged 1 commit intomainfrom Dec 15, 2025
Merged
Conversation
|
[BOT] Preview available with hash |
|
|
🥷 Code experts: tf-security tf-security has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
Thr44
approved these changes
Dec 15, 2025
typeform-ops-gha
pushed a commit
that referenced
this pull request
Dec 15, 2025
# [@typeform/embed-v5.9.0](https://github.com/Typeform/embed/compare/@typeform/embed-v5.8.0...@typeform/embed-v5.9.0) (2025-12-15) ### Features * **TU-34343:** Create a new AWS deploy workflow ([#726](#726)) ([0dc8fb4](0dc8fb4))
|
🎉 This PR is included in version @typeform/embed-v5.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
semantic-releaseby creating a separate workflow triggered by GitHub release eventsWhy
The current release flow is convoluted and hard to follow, focusing on
embedsinceembed-reactis NOT deployed to AWS:New approach:
This still only deploys to AWS when there are actual changes - since the AWS workflow only triggers when a GitHub release is created, and releases only happen when
semantic-releasedetects releasable commits.I am expecting that it will trigger when
embedORembed-reactGitHub releases are published, but the IF condition on the workflow should mean it runs for the former and is skipped for the latter.