Skip to content

fix(run_manifest_validation): Declare earlier manifest schema versions as now supported#250

Merged
RandomByte merged 5 commits intoUI5:mainfrom
s-todorova:lower-schema-versions
Mar 6, 2026
Merged

fix(run_manifest_validation): Declare earlier manifest schema versions as now supported#250
RandomByte merged 5 commits intoUI5:mainfrom
s-todorova:lower-schema-versions

Conversation

@s-todorova
Copy link
Contributor

@s-todorova s-todorova commented Feb 23, 2026 •
edited by flovogt
Loading

  • Enables support for schema versions using Draft 07
  • Includes a workaround for schema version 1.68.0 (bug report is made)

JIRA: BGSOFUIRODOPI-3610

@s-todorova s-todorova force-pushed the lower-schema-versions branch 2 times, most recently from 55a59af to 1aa4b72 Compare February 23, 2026 13:52
RandomByte
RandomByte reviewed Feb 24, 2026
View reviewed changes
@RandomByte
Copy link
Member

RandomByte commented Feb 24, 2026

Thank you for this improvement! Please let us know once it is ready for review from our side. I just added one comment after glancing over the changes.

@s-todorova
Copy link
Contributor Author

s-todorova commented Feb 24, 2026

Thank you for this improvement! Please let us know once it is ready for review from our side. I just added one comment after glancing over the changes.

Thank you for quick response, it is ready for review.

@s-todorova s-todorova force-pushed the lower-schema-versions branch from 3d8de1f to 7d52037 Compare February 24, 2026 09:19
@RandomByte RandomByte requested a review from a team February 24, 2026 09:32
@dimovpetar
Copy link
Member

dimovpetar commented Feb 25, 2026

Schemas v1.50.0, v1.58.0 and v1.61.0 are missing from https://github.com/UI5/manifest. No need to do anything from in the tool, but please report this as issue.

@s-todorova
Copy link
Contributor Author

s-todorova commented Feb 25, 2026

Schemas v1.50.0, v1.58.0 and v1.61.0 are missing from https://github.com/UI5/manifest. No need to do anything from in the tool, but please report this as issue.

UI5/manifest#35

dimovpetar
dimovpetar suggested changes Feb 25, 2026
View reviewed changes
@s-todorova s-todorova force-pushed the lower-schema-versions branch 3 times, most recently from e90c8c8 to 4092062 Compare February 26, 2026 14:41
@flovogt flovogt requested a review from dimovpetar February 27, 2026 08:59
dimovpetar
dimovpetar suggested changes Feb 27, 2026
View reviewed changes
@s-todorova s-todorova force-pushed the lower-schema-versions branch from 81452ee to 59fa88e Compare February 27, 2026 13:24
@flovogt flovogt requested a review from RandomByte February 27, 2026 13:33
RandomByte
RandomByte reviewed Mar 5, 2026
View reviewed changes
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed review. The change looks great, just got one question

@RandomByte RandomByte merged commit dfe5c91 into UI5:main Mar 6, 2026
15 checks passed
@RandomByte
Copy link
Member

RandomByte commented Mar 6, 2026

Thanks for the contribution! We will release this soon

@openui5bot openui5bot mentioned this pull request Mar 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RandomByte RandomByte RandomByte approved these changes

+1 more reviewer

@dimovpetar dimovpetar dimovpetar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dimovpetar dimovpetar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@s-todorova @RandomByte @dimovpetar