Added support for object urls to URLListValidator.js#4055
Open
igzThomasFrischholz wants to merge 2 commits intoUI5:masterfrom
Open
Added support for object urls to URLListValidator.js#4055igzThomasFrischholz wants to merge 2 commits intoUI5:masterfrom
igzThomasFrischholz wants to merge 2 commits intoUI5:masterfrom
Conversation
|
|
Member
|
Thanks a lot for your PR. The team will have a look at it! |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URLListValidator did not support Object-URLs which lead to misbehaviour in some classes. (e.g PDFViewer could not load files from object urls)
This PR aims to fix this issue by adding a regex check and decompose into the validate method of URLListValidator.js
A separate Unit-Test for the desired behavior has been added as well.