Skip to content

refactor(ui5-slider): slider handle and scale extraction #13033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MapTo0 merged 7 commits into from
Feb 25, 2026
+1,480 −337
Merged

refactor(ui5-slider): slider handle and scale extraction #13033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
160781b
refactor(ui5-slider): slider handle extraction
MapTo0 Feb 5, 2026
fe25fa2
Merge branch 'main' into slider-refactoring-2
ilhan007 Feb 9, 2026
be21665
fix: review feedback applied
MapTo0 Feb 18, 2026
0514538
fix: review feedback applied
MapTo0 Feb 19, 2026
a16f7f3
fix: colorpicker test
MapTo0 Feb 19, 2026
3c8ee77
fix: review feedback
MapTo0 Feb 23, 2026
30e04ac
Merge remote-tracking branch 'origin/main' into HEAD
MapTo0 Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/main/cypress/specs/ColorPicker.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ describe("Color Picker general interaction tests", () => {
.realClick({ position: "center" });

cy.get<ColorPicker>("@colorPicker")
.should("have.value", "rgba(64, 191, 189, 1)");
.should("have.value", "rgba(64, 191, 191, 1)");
Copy link
Contributor Author

@MapTo0 MapTo0 Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsanislavgatev I believe this test used to be wrong? Could you please confirm? the Slider' value is now correct from 0 to 360, clicking center should count as value 180

Copy link
Contributor

@tsanislavgatev tsanislavgatev Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't say wrong, but testing on the current slider behaviour. Both colors are almost identical. They resolve to #40bfbf and #40bfbd which doesn't really have a noticable difference. The change in the test is okay, but I would say it just tests the behaviour of the component based on the behaviour of the slider.

});

it("should update value when alpha is changed via the Alpha slider", () => {
Expand Down
Loading
Loading