Skip to content

fix(ui5-time-picker): apply AM/PM selection on Enter key #13097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hinzzx wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(ui5-time-picker): apply AM/PM selection on Enter key #13097

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95af9bf
fix(ui5-time-picker): apply AM/PM selection on Enter key
hinzzx Feb 16, 2026
59ea4b7
use segmented button getter
hinzzx Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/main/src/TimeSelectionClocks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,14 @@ class TimeSelectionClocks extends TimePickerInternals {
const toggleSpinButtonTarget = evt.target && (evt.target as HTMLElement).tagName.toLowerCase().indexOf("segmented") === -1;

if (isEnter(evt)) {
// If Enter is pressed on AM/PM segmented button, apply the period change first
if (this._amPmFocused) {
const buttonAmPm = this._buttonAmPm();
const selectedItem = buttonAmPm?.selectedItems[0];
if (selectedItem?.textContent) {
this._calculatePeriodChange(selectedItem.textContent);
}
}
// Accept the time and close the popover
this.fireDecoratorEvent("close-picker");
} else if (isSpace(evt) && toggleSpinButtonTarget && !this._spacePressed) {
Expand Down
Loading