fix(ui5-side-navigation): fix footer separator margins#13117
Open
LidiyaGeorgieva wants to merge 1 commit intomainfrom
Open
fix(ui5-side-navigation): fix footer separator margins#13117LidiyaGeorgieva wants to merge 1 commit intomainfrom
LidiyaGeorgieva wants to merge 1 commit intomainfrom
Conversation
The margins of the footer separator were not correctly applied in some cases: - Side Navigation samples page in the Playground - Fiori 3 theme + Compact density in the Test pages To fix those, the parameters were simplified. JIRA: 3598 / P1-34776
LidiyaGeorgieva
requested review from
TeodorTaushanov,
dimovpetar and
nnaydenow
Collaborator
|
🚀 Deployed on https://pr-13117--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The margins of the footer separator were not correctly applied in some cases:
To fix those, the parameters were simplified.
JIRA: 3598 / P1-34776