Conversation
Collaborator
|
🚀 Deployed on https://pr-13128--ui5-webcomponents-preview.netlify.app |
nnaydenow
requested review from
ilhan007,
pskelin and
vladitasev
and removed request for
vladitasev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add scoped CSS variables (--ui5-sap*) alongside default --sap* variables to support custom themes built on older theme bases with missing variables.
The parameters-bundle.css now provides two files per theme:
Scoped variables serve as fallback values when external themes are loaded, ensuring components have proper theming even with incomplete custom themes. This works because UI5 Web Components skip loading the theme base when external themes are present.
A new skipThemeBase configuration option allows preventing the loading of default --sap* variables when needed.
Fixes: #12446