Skip to content

Feature/cdd 2964 cms refactor download components #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manubinary merged 10 commits into from
Dec 15, 2025

Merge branch 'main' into feature/CDD-2964-CMS-refactor-Download-compo…

298432c
Select commit
Loading
Failed to load commit list.
Merged

Feature/cdd 2964 cms refactor download components #794

Merge branch 'main' into feature/CDD-2964-CMS-refactor-Download-compo…
298432c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Dec 11, 2025 in 37s

Quality Gate passed

Issues
25 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
38.2% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 69 in src/app/components/ui/ukhsa/Download/SubplotClientDownload.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest functions more than 4 levels deep. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKQ_09Rot4VeFJuf&open=AZq9AKQ_09Rot4VeFJuf&pullRequest=794

Check warning on line 59 in src/app/components/ui/ukhsa/Download/SubplotClientDownload.spec.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Don't use a zero fraction in the number. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKR309Rot4VeFJus&open=AZq9AKR309Rot4VeFJus&pullRequest=794

Check warning on line 40 in src/app/components/ui/ukhsa/Download/SubplotDownloadForm.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'formData.get('file_format')' may use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKST09Rot4VeFJuw&open=AZq9AKST09Rot4VeFJuw&pullRequest=794

Check warning on line 29 in src/app/components/ui/ukhsa/Download/SubplotClientDownload.spec.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Don't use a zero fraction in the number. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKR309Rot4VeFJun&open=AZq9AKR309Rot4VeFJun&pullRequest=794

Check warning on line 16 in src/app/components/ui/ukhsa/Download/SubplotDownloadForm.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKST09Rot4VeFJuv&open=AZq9AKST09Rot4VeFJuv&pullRequest=794

Check failure on line 214 in src/app/components/ui/ukhsa/Download/DownloadForm.spec.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `return value` over `return Promise.resolve(value)`. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKSF09Rot4VeFJuu&open=AZq9AKSF09Rot4VeFJuu&pullRequest=794

Check warning on line 52 in src/app/components/ui/ukhsa/Download/DownloadForm.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Handle this exception or don't catch it at all. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKKw09Rot4VeFJub&open=AZq9AKKw09Rot4VeFJub&pullRequest=794

Check warning on line 47 in src/app/components/ui/ukhsa/Download/SubplotDownloadForm.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Handle this exception or don't catch it at all. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKST09Rot4VeFJux&open=AZq9AKST09Rot4VeFJux&pullRequest=794

Check warning on line 16 in src/app/components/ui/ukhsa/Download/Download.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKQI09Rot4VeFJuc&open=AZq9AKQI09Rot4VeFJuc&pullRequest=794

Check warning on line 34 in src/app/components/ui/ukhsa/Download/SubplotClientDownload.spec.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Don't use a zero fraction in the number. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKR309Rot4VeFJuo&open=AZq9AKR309Rot4VeFJuo&pullRequest=794

Check warning on line 17 in src/app/components/ui/ukhsa/Download/DownloadForm.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKKw09Rot4VeFJuZ&open=AZq9AKKw09Rot4VeFJuZ&pullRequest=794

Check warning on line 54 in src/app/components/ui/ukhsa/Download/SubplotClientDownload.spec.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Don't use a zero fraction in the number. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKR309Rot4VeFJur&open=AZq9AKR309Rot4VeFJur&pullRequest=794

Check warning on line 16 in src/app/components/ui/ukhsa/Download/ClientDownload.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'cardData' PropType is defined but prop is never used 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKRN09Rot4VeFJuh&open=AZq9AKRN09Rot4VeFJuh&pullRequest=794

Check warning on line 94 in src/app/components/ui/ukhsa/Download/ClientDownload.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKRN09Rot4VeFJuj&open=AZq9AKRN09Rot4VeFJuj&pullRequest=794

Check warning on line 116 in src/app/components/ui/ukhsa/Download/SubplotClientDownload.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKQ_09Rot4VeFJug&open=AZq9AKQ_09Rot4VeFJug&pullRequest=794

Check failure on line 95 in src/app/components/ui/ukhsa/Download/SubplotDownloadForm.spec.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `return value` over `return Promise.resolve(value)`. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKRo09Rot4VeFJul&open=AZq9AKRo09Rot4VeFJul&pullRequest=794

Check warning on line 46 in src/app/components/ui/ukhsa/Download/DownloadForm.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'formData.get('format')' may use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKKw09Rot4VeFJua&open=AZq9AKKw09Rot4VeFJua&pullRequest=794

Check failure on line 17 in src/app/components/ui/ukhsa/Download/Download.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected `await` of a non-Promise (non-"Thenable") value. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKQI09Rot4VeFJud&open=AZq9AKQI09Rot4VeFJud&pullRequest=794

Check warning on line 19 in src/app/components/ui/ukhsa/Download/ClientDownload.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKRN09Rot4VeFJui&open=AZq9AKRN09Rot4VeFJui&pullRequest=794

Check failure on line 169 in src/app/components/ui/ukhsa/Download/DownloadForm.spec.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `return value` over `return Promise.resolve(value)`. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKSF09Rot4VeFJut&open=AZq9AKSF09Rot4VeFJut&pullRequest=794

Check warning on line 28 in src/app/components/ui/ukhsa/Download/SubplotClientDownload.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKQ_09Rot4VeFJue&open=AZq9AKQ_09Rot4VeFJue&pullRequest=794

Check failure on line 121 in src/app/components/ui/ukhsa/Download/SubplotDownloadForm.spec.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `return value` over `return Promise.resolve(value)`. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKRo09Rot4VeFJum&open=AZq9AKRo09Rot4VeFJum&pullRequest=794

Check warning on line 39 in src/app/components/ui/ukhsa/Download/SubplotClientDownload.spec.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Don't use a zero fraction in the number. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKR309Rot4VeFJup&open=AZq9AKR309Rot4VeFJup&pullRequest=794

Check warning on line 49 in src/app/components/ui/ukhsa/Download/SubplotClientDownload.spec.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Don't use a zero fraction in the number. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKR309Rot4VeFJuq&open=AZq9AKR309Rot4VeFJuq&pullRequest=794

Check warning on line 39 in src/app/components/ui/ukhsa/Download/Download.spec.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Don't use a zero fraction in the number. 

See more on https://sonarcloud.io/project/issues?id=UKHSA-Internal_winter-pressures-frontend&issues=AZq9AKRa09Rot4VeFJuk&open=AZq9AKRa09Rot4VeFJuk&pullRequest=794
View more details on SonarQubeCloud