Conversation
… feat-120-assigment_dashboard
…mail_notification
…er to assignments and submissions
…_email_notification
…cation Feat 145 assignments email notification
dennis-zyska
left a comment
dennis-zyska
left a comment
There was a problem hiding this comment.
Thank you, nice and fast implementation, I made some comments for improvements. Note that I didn't run the branch yet, so the feedback is only on the code. There are also some merge conflicts.
There was a problem hiding this comment.
Can't we add this in the assignment creation migration? As long it is not merged to dev, I think it would be fine to do so. I'm also thinking, maybe it directly make sense here to adapt it also with an additional table instead of an array. Arrays in db tables are always a bad idea (also see https://en.wikipedia.org/wiki/Database_normalization)
| }, | ||
| }, | ||
| methods: { | ||
| isAssignmentOwner(assignment) { |
There was a problem hiding this comment.
I think we can directly do it in the compute. I know it is used twice, but I think here it is more important to directly be able to see what is compared
There was a problem hiding this comment.
we should not call it AdminAssignmentsView.vue, better would be to have right, that we give admins to use this. In that way we can in the future in principle give this also another role and keep this more general
| assignmentTable() { | ||
| return this.assignments.map((assignment) => ({ | ||
| ...assignment, | ||
| isOwner: this.isAssignmentOwner(assignment), |
There was a problem hiding this comment.
here I would also remove the function and show it directly, because of the clearness
There was a problem hiding this comment.
wdym by show it directly? i feel it's clear enough
| <Card title="Submissions"> | ||
| <template #headerElements> | ||
| <div class="btn-group gap-2"> | ||
| <BasicButton |
There was a problem hiding this comment.
Where are all the remove buttons and functionalities? I didn't find it, in which dashboard?
There was a problem hiding this comment.
which butotn are you refferring too
3 participants
Main Description
Implemented an Assignment Dashboard flow that shifts submission handling from admin-only/manual import to assignment-based self-service uploads, enabling both admins and users to manage submissions and revision workflows.
User Features
description)studyUsageCountSystem Features
Assignment Data Model
title,description,publicstudyId,workflowId,userIdstart,end,closedvalidationConfigurationIdassignedRoleIdsparentAssignmentId,previousSubmissionAssignmentIdallowReUpload,maxRevisionsdeleted,deletedAt,createdAt,updatedAtSubmission Model Updates
name,description(metadata)assignmentId(linkage)Access Control
Submission Pipeline
Validation & Rules
Revision Control
revision X)Study Protection
studyUsageCountKnown Limitations