feat(apollo-vertex): dashboard card renderers — InsightCardBody and typed card content components#823
Open
frankkluijtmans wants to merge 3 commits into
Open
feat(apollo-vertex): dashboard card renderers — InsightCardBody and typed card content components#823frankkluijtmans wants to merge 3 commits into
frankkluijtmans wants to merge 3 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Dependency License Review
License distribution
Excluded packages
|
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…yped card content components Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
frankkluijtmans
force-pushed
the
pr/3-dashboard-renderers
branch
from
9df6c10 to
97a7d33
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new client-side renderer layer for Apollo Vertex dashboard insight cards. InsightCardBody selects a content renderer (KPI, horizontal bars, donut, sparkline, stacked bar, or area) based on the card config and view mode, bridging dashboard data to card visuals.
Changes:
- Introduces
InsightCardBodyand multiple chart/KPI content renderers in a single module. - Adds compact/expanded rendering variants for horizontal bars and stacked bars.
- Adds a
TruncatedTexthelper that conditionally shows a tooltip when text is clamped.
Comment on lines
+423
to
+425
| if (content.type === "kpi") { | ||
| return <KpiContent cardData={cardData} viewMode={viewMode} />; | ||
| } |
- Wire donut, sparkline, and area renderers to dataset values (donutPercent/donutLabel/points) with sample fallbacks - Guard percentage math against divide-by-zero and empty data so legends and bar heights never render NaN% - Key stacked-bar totals and segments by category index instead of CSS color, which repeats once there are more than 5 categories - Make the TruncatedText tooltip trigger keyboard-focusable when clamped Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Addressed the Copilot review in a follow-up commit ( Two items I intentionally did not change, for the record:
Note: |
- Clamp donut fraction to [0,1] so out-of-range data can't produce a negative/oversized arc or a wrong label. - Normalize expanded horizontal-bar percentages to value/total so they match the compact view (bar values are raw counts, not percentages). - Return null from InsightCardBody when cardIndex is out of range instead of silently rendering insightCards[0]. - Replace the chart renderer if-chain with an exhaustive switch and a never guard so a new ChartType fails to compile rather than defaulting to Area. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ruudandriessen
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the rendering logic that turns raw data into card content.
InsightCardBodydecides whether a card should show a KPI number, a horizontal bar chart, a donut, a sparkline, or an area chart based on the card'stypeandchartTypefields. This is the layer between the data model and the visual cards.Rebased onto
main— the dashboard foundation and config layer it was previously stacked on have since merged, so this now contains only the new renderer logic (insight-card-renderers.tsx).Supersedes #732, which could not be reopened after its head branch was rebased/force-pushed.
Test plan
insight-card-renderers.tsxtypeandchartTypecombinations are handled🤖 Generated with Claude Code