feat(subscriptions): publisher/group-level updates (PR 6/7)#518
Open
sarthak688 wants to merge 2 commits into
Open
feat(subscriptions): publisher/group-level updates (PR 6/7)#518sarthak688 wants to merge 2 commits into
sarthak688 wants to merge 2 commits into
Conversation
…er, updateTopicGroup) Adds the two broader-scope subscription writes: - updatePublisher: opt-in/out at the publisher level, optionally scoped to specific entities (folders, etc.) - updateTopicGroup: scope a named topic group to a set of entities API spec misspells the publisher key as `publisherID`; the SDK preserves the typo at send time and keeps the public surface clean (`publisherId`). Adds PublisherSubscriptionUpdate + TopicGroupSubscriptionUpdate types, response types, oauth-scopes entries, 5 new unit tests, and an updatePublisher round-trip integration test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Jun 12, 2026
Contributor
|
✅ No issues found. Checked for bugs and CLAUDE.md compliance. |
…uth-scopes entries Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
✅ No issues found. Checked for bugs and CLAUDE.md compliance. |
| * { publisherId: '<publisherId>', isUserOptIn: false }, | ||
| * ]); | ||
| * ``` | ||
| * @internal |
Contributor
There was a problem hiding this comment.
if these methods are public dont mark them as internal. Check for other similar methods as well
Contributor
|
in PR description u mentioned docs/oauth scopes have also changed but i dont see it , is that part of another dependent PR? |
| // Intentional duplicate URL of GET_ALL: same path, POST vs GET differentiates the operation. | ||
| UPDATE_TOPIC: `${SUBSCRIPTION_API_BASE}/api/v1/UserSubscription`, | ||
| UPDATE_CATEGORY: `${SUBSCRIPTION_API_BASE}/api/v1/UserSubscription/CategorySubscription`, | ||
| UPDATE_PUBLISHER: `${SUBSCRIPTION_API_BASE}/api/v1/UserSubscription/PublisherSubscription`, |
Contributor
There was a problem hiding this comment.
add js doc for remaining constants as well like u have done for UPDATE_TOPIC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 6/7 in the Notification SDK stack. Stacked on top of #517.
Adds the two broader-scope subscription writes — publisher-level opt-in/out and topic-group entity scoping.
Methods Added
subscriptions.updatePublisher()updatePublisher(tenantId: string, subscriptions: PublisherSubscriptionUpdate[]): Promise<SubscriptionUpdatePublisherResponse>subscriptions.updateTopicGroup()updateTopicGroup(tenantId: string, subscriptions: TopicGroupSubscriptionUpdate[]): Promise<SubscriptionUpdateTopicGroupResponse>Endpoints Called
updatePublisher()notificationservice_/usersubscriptionservice/api/v1/UserSubscription/PublisherSubscriptionNotificationServiceupdateTopicGroup()notificationservice_/usersubscriptionservice/api/v1/UserSubscription/TopicGroupSubscriptionNotificationServicepublisherID(sic), notpublisherId. The SDK's public surface uses the clean spelling; the rename happens at send time insideupdatePublisher.updatePublishersupports optional entity scoping (e.g. opt in for two specific folders only);updateTopicGroupalways scopes a named topic group to a list of entities.Example Usage
Verification
npm run typechecknpm run lintnpm run test:unitIntegration:
updatePublisherround-trip — flip the user's opt-in for the first visible publisher, then restore.updateTopicGroupis unit-only because it needs a configured topic group on the test tenant.Files
src/utils/constants/endpoints/notification.ts(UPDATE_PUBLISHER,UPDATE_TOPIC_GROUP)src/models/notification/subscriptions.types.ts(PublisherSubscriptionUpdate,TopicGroupSubscriptionUpdate)src/models/notification/subscriptions.models.ts(response types + ServiceModel methods)src/services/notification/subscriptions.tstests/unit/services/notification/subscriptions.test.ts(+5 tests)tests/integration/shared/notification/subscriptions.integration.test.ts(+1 round-trip test)docs/oauth-scopes.mdPR Stack
feat/notifications-sdkfeat/notifications-mark-readfeat/notifications-deletefeat/subscriptions-sdkfeat/subscriptions-topic-updatesfeat/subscriptions-publisher-updates(this PR)feat/subscriptions-mode-reset🤖 Generated with Claude Code