add basic keyboard navigation to search#237
Open
JFrankfurt wants to merge 2 commits intoUniswap:v2from
Open
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/uniswap/uniswap-info/mi98n9ikt |
JFrankfurt
changed the title
JFrankfurt
force-pushed
the
add-keyboard-search-nav
branch
from
3877bbb to
4c0141d
Compare
JFrankfurt
force-pushed
the
add-keyboard-search-nav
branch
from
4c0141d to
f4dd3f0
Compare
Contributor
|
Thanks for working on this regardless - been on the to do list forever. Let me know you have questions |
JFrankfurt
force-pushed
the
add-keyboard-search-nav
branch
from
f4dd3f0 to
53cc856
Compare
Contributor
Author
|
@ianlapham finally came back to this. The vercel review app is still the initial commit though.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came back to this after some sleep and it looks like it still needs work. Don't merge as is.
Looks like the lint:fix script added useEffect dependencies that broke the intended behavior.