Request 2 thrines in ThrinesBenchmark to match other implementations - #22
Open
fizruk wants to merge 1 commit into
Open
Request 2 thrines in ThrinesBenchmark to match other implementations#22fizruk wants to merge 1 commit into
fizruk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThrinesBenchmarkcallsfindThrines(3), while the corresponding benchmarks for other miniKanren implementations request 2 thrines. In particular, the OCanren and faster-miniKanren benchmarks in miniKanren_exec_order (the setup used for the klogic paper's cross-language comparison, if I understand correctly) both take 2 answers, and so does the typedKanren benchmark suite which builds on it. Since the search space grows quickly between consecutive thrines, requesting a third answer makes this benchmark solve a substantially harder query than the others, so klogic's thrines numbers come out worse than they should in cross-language comparisons.To estimate the effect, I ran the suite on an Apple M-series machine (JMH, JDK 21): with
findThrines(3)the benchmark takes ~2620 ms, withfindThrines(2)it takes ~1630 ms, i.e. the current setting inflates the thrines result by roughly 1.6x.