Fix switch fall-through in crn_decompress_block#11
Fix switch fall-through in crn_decompress_block#11zellski wants to merge 1 commit intoUnity-Technologies:unityfrom
Conversation
Do not immediately overwrite our DXT5-decompressed pixels with a cCRNFmtDXN_XY interpretation.
|
Hi, as one of the maintainer of the @DaemonEngine fork (see https://github.com/DaemonEngine/crunch), I'm interested in merging the fixes people submit if those fixes are not so much intrusive and/or if they fixes obvious bugs that has to be fixed in any way. @zellski can you confirm
If you can answer Yes to all those questions I may merge your fix in @DaemonEngine fork which is actively maintained to bring fixes while keeping in sync with upstream, hoping for a merge one day, see DaemonEngine#2. Thank you in advance. |
|
Uh, no, I can't confirm all that, but it's a bugfix and you're free to use it. |
|
@zellski by bugfix do you mean the current code (without your patch) is always wrong? |
|
I do not understand the code behind, since I don't know the algo and format, but here, a compiler would warn about fallthrough, and it's the only case in which there's a fallthrough. |
Do not immediately overwrite our DXT5-decompressed pixels with a cCRNFmtDXN_XY interpretation.