Skip to content

Conversation

@ErliSoares
Copy link
Contributor

Description

When instantiating UnleashClient with cache set to cache.bootstrapped = True, the error Error loading features: 'BootstrapConnector' object has no attribute 'ready_callback' is returned.

The error occurs when calling the code block below. I was wondering if it's necessary, if initialize_client isn't the same thing.

if self.unleash_bootstrapped:
BootstrapConnector(
engine=self.engine,
cache=self.cache,
).start()

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests
  • Spec Tests
  • Integration tests / Manual Tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19613145001

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 93.411%

Files with Coverage Reduction New Missed Lines %
UnleashClient/connectors/base_connector.py 3 78.13%
Totals Coverage Status
Change from base Build 18272747945: -0.4%
Covered Lines: 638
Relevant Lines: 683

💛 - Coveralls

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with @sighphyre and this looks fine
Thanks for the contribution!

@github-project-automation github-project-automation bot moved this from New to Approved PRs in Issues and PRs Nov 26, 2025
@gastonfournier gastonfournier merged commit 7951d32 into Unleash:main Nov 26, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from Approved PRs to Done in Issues and PRs Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants