[k2] implemented aes-128-gcm, aes-256-gcm + supported "no padding" in f$openssl_encrypt and f$openssl_decrypt builtins#1517
Conversation
apolyakov
left a comment
There was a problem hiding this comment.
We've decided to make these changes backward compatible, so this PR needs some changes
71356ef to
9c32191
Compare
apolyakov
left a comment
There was a problem hiding this comment.
Comment 1: Typo (line 301, 379)
"doesn not" → "does not"
Comment 2: Misleading variable names (lines 316, 391)
cbc_encrypt/cbc_decrypt → encrypt/decrypt (now handles both CBC and GCM)
Comment 3: Simplify AEAD validation (lines 292-302, 346-352)
Validation is scattered across the function. Consider consolidating into one block. Also, line 348's warning says "when using AEAD mode" but is reached when NOT in AEAD mode.
Comment 4: Add comment (line 234-238)
Consider adding a comment that IV length validation is handled by the crypto component (differs from legacy runtime).
Comment 5: Missing GCM in cipher methods (lines 268-272)
Add AES_128_GCM and AES_256_GCM to the return value.
bbfeb0f to
7fa4957
Compare
|
|
… tl::String from response stream
c286be0 to
4a16163
Compare
No description provided.