Skip to content

Conversation

@imwqqz
Copy link

@imwqqz imwqqz commented Dec 16, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 16, 2025 03:10
@imwqqz
Copy link
Author

imwqqz commented Dec 16, 2025

Refer Issue: #6

@imwqqz
Copy link
Author

imwqqz commented Dec 16, 2025

Modified Readme Refer PR: #4

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for Windows 11 25H2 build 26200.7462 by adding a new signature pattern to locate ntokrnl.exe offsets. Additionally, it updates the README to clarify the LLVM requirement and document the build process including the stripping step.

Key changes:

  • Adds a new signature pattern for Windows 11 25H2 build 26200.7462 to locate kernel offsets
  • Documents LLVM Compiler Infrastructure as a build requirement
  • Updates build output path documentation from .sys to .dll and adds information about the Strip-Driver.ps1 step

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
driver/src/offsets.rs Adds new signature pattern for Windows 11 25H2 26200.7462 ntokrnl.exe offset detection
README.MD Updates build requirements and clarifies the build process including the driver stripping step

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +113 to +117
Signature::offset(
obfstr!("_EPROCESS.ThreadListHead (26200.7462)"),
obfstr!("4C 8D B1 ? ? ? ? 48 8B F2"),
0x03,
),
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This signature appears to be in the wrong array. The signature is labeled as "_EPROCESS.ThreadListHead (26200.7462)" which suggests it should be searching for the ThreadListHead offset, but it's placed in the ps_get_next_process array. This signature should be moved to the eprocess_thread_list_head array (around line 163-187) where other ThreadListHead signatures are located.

Copilot uses AI. Check for mistakes.
obfstr!("4C 8D B1 ? ? ? ? 48 8B F2"),
0x03,
),

Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected. Remove the trailing whitespace at the end of this line to maintain code consistency.

Copilot uses AI. Check for mistakes.

- Visual Studio 2022
- Windows Kernel Development Kit
- LLVM Compiler Infrastructure
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected. Remove the trailing whitespace at the end of this line to maintain code consistency.

Suggested change
- LLVM Compiler Infrastructure
- LLVM Compiler Infrastructure

Copilot uses AI. Check for mistakes.
# The result will be located at "../target/x86_64-pc-windows-msvc/release/valthrun-driver.dll"
cargo b -r
# Now we Strip the driver to get valthrun-driver.sys via Strip-Driver.ps1 linking input to espected realese build "../target/x86_64-pc-windows-msvc/release/valthrun-driver.dll".
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "espected" should be "expected".

Suggested change
# Now we Strip the driver to get valthrun-driver.sys via Strip-Driver.ps1 linking input to espected realese build "../target/x86_64-pc-windows-msvc/release/valthrun-driver.dll".
# Now we Strip the driver to get valthrun-driver.sys via Strip-Driver.ps1 linking input to expected realese build "../target/x86_64-pc-windows-msvc/release/valthrun-driver.dll".

Copilot uses AI. Check for mistakes.
# The result will be located at "../target/x86_64-pc-windows-msvc/release/valthrun-driver.dll"
cargo b -r
# Now we Strip the driver to get valthrun-driver.sys via Strip-Driver.ps1 linking input to espected realese build "../target/x86_64-pc-windows-msvc/release/valthrun-driver.dll".
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "realese" should be "release".

Suggested change
# Now we Strip the driver to get valthrun-driver.sys via Strip-Driver.ps1 linking input to espected realese build "../target/x86_64-pc-windows-msvc/release/valthrun-driver.dll".
# Now we Strip the driver to get valthrun-driver.sys via Strip-Driver.ps1 linking input to expected release build "../target/x86_64-pc-windows-msvc/release/valthrun-driver.dll".

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant