-
Notifications
You must be signed in to change notification settings - Fork 288
Add customisable hotkey binds #1705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
1ccf22e to
8834afd
Compare
|
Hmmm, this has a decent amount of overlap with fef0bca I wonder if these two things can be merged. We should also make this configurable from lua. |
|
Oh neat, I can have a go at frankensteining something together |
8834afd to
d89ce3b
Compare
799653a to
4d66df1
Compare
5f1a8fa to
833cbab
Compare
|
Alright, I've ported the code to use the gamescope_action_binding protocol, and added configuration via lua. Couple things I'm still unsure about: We probably want default keys + commands defined somewhere in cpp-land in case the lua config file doesn't exist. Starting another thread for hotkeys feels icky, but wlserver has to be running in order to bind actions, and I wasn't sure where else to put it. |
|
Can we make this not just execute a command, but just run a lua function that can do that? |
eb1f82d to
58a9714
Compare
|
Added a lua function for running ConCommands.
|
58a9714 to
a6afd30
Compare
a6afd30 to
5d9ad24
Compare
This PR moves hotkey handling out of backends and adds configuration via lua. Adds support for issue #457.