Fix - vibium:element.text returns innerText instead of textContent - #216
Closed
Jhoan0714 wants to merge 2 commits into
Closed
Fix - vibium:element.text returns innerText instead of textContent#216Jhoan0714 wants to merge 2 commits into
Jhoan0714 wants to merge 2 commits into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #215 the
vibium:element.textwire handler soel.text()returns text content (textContent) instead of inner text (innerText), matchingdocs/reference/api.mdand the handler comment in Go.Root Cause
handleVibiumElTextinclicker/internal/api/handlers_state.goevaluated(el.innerText || '').trim()even though the comment and API docs describetextContentbehavior. As a result,el.text()behaved identically toel.inner_text()for elements with hidden descendants.Why this matters
text()andinner_text()/innerText()api.md)Validation
Executed:
Before fix:
After fix: