Skip to content

helm-converter: multiple fixes#2395

Merged
AndrewChubatiuk merged 3 commits into
masterfrom
converter-multiple-fixes
Jul 21, 2026
Merged

helm-converter: multiple fixes#2395
AndrewChubatiuk merged 3 commits into
masterfrom
converter-multiple-fixes

Conversation

@AndrewChubatiuk

@AndrewChubatiuk AndrewChubatiuk commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

fixes #2391
fixes #2390
fixes #2389
fixes #2398
fixes #2397

@AndrewChubatiuk
AndrewChubatiuk requested a review from vrutkovs as a code owner July 9, 2026 20:15
@AndrewChubatiuk
AndrewChubatiuk marked this pull request as draft July 9, 2026 20:15

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread internal/converter/converter.go
Comment thread internal/converter/converter.go
@AndrewChubatiuk
AndrewChubatiuk force-pushed the converter-multiple-fixes branch 3 times, most recently from 2b4a80c to 02e93f7 Compare July 17, 2026 06:37
@AndrewChubatiuk
AndrewChubatiuk marked this pull request as ready for review July 17, 2026 07:09

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread cmd/helm-converter/main.go Outdated
@AndrewChubatiuk
AndrewChubatiuk force-pushed the converter-multiple-fixes branch 2 times, most recently from 9e69029 to afb7ee2 Compare July 17, 2026 07:38
Comment thread internal/converter/converter.go Outdated
Co-authored-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
Signed-off-by: Andrii Chubatiuk <andrew.chubatiuk@gmail.com>
@AndrewChubatiuk
AndrewChubatiuk enabled auto-merge (squash) July 21, 2026 07:52
Signed-off-by: Andrii Chubatiuk <achubatiuk@victoriametrics.com>
@AndrewChubatiuk
AndrewChubatiuk force-pushed the converter-multiple-fixes branch from 4e0bee5 to d3f652b Compare July 21, 2026 08:00
@AndrewChubatiuk
AndrewChubatiuk merged commit 15b2ec9 into master Jul 21, 2026
8 of 9 checks passed
@AndrewChubatiuk
AndrewChubatiuk deleted the converter-multiple-fixes branch July 21, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment