Skip to content

helm-coverter: support extraVolumes/extraVolumeMounts#2425

Merged
AndrewChubatiuk merged 1 commit into
masterfrom
converter-support-extra-volumes
Jul 21, 2026
Merged

helm-coverter: support extraVolumes/extraVolumeMounts#2425
AndrewChubatiuk merged 1 commit into
masterfrom
converter-support-extra-volumes

Conversation

@AndrewChubatiuk

Copy link
Copy Markdown
Contributor

fixes #2424

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/converter/converter.go">

<violation number="1" location="internal/converter/converter.go:1097">
P3: The test coverage for VLogs, VTSingle, VTCluster, VLAgent, VLCollector, and VMAuth with extraVolumes/extraVolumeMounts is not included. Consider adding tests for all affected chart types to match the thorough coverage already provided for VMSingle, VMAgent, VMAlert, VMAnomaly, and VLCluster.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

spec.PodMetadata = cfg.PodMetadata
spec.ServiceSpec = cfg.ServiceSpec
spec.Storage = cfg.Storage
spec.Volumes = cfg.Volumes

@cubic-dev-ai cubic-dev-ai Bot Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The test coverage for VLogs, VTSingle, VTCluster, VLAgent, VLCollector, and VMAuth with extraVolumes/extraVolumeMounts is not included. Consider adding tests for all affected chart types to match the thorough coverage already provided for VMSingle, VMAgent, VMAlert, VMAnomaly, and VLCluster.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At internal/converter/converter.go, line 1097:

<comment>The test coverage for VLogs, VTSingle, VTCluster, VLAgent, VLCollector, and VMAuth with extraVolumes/extraVolumeMounts is not included. Consider adding tests for all affected chart types to match the thorough coverage already provided for VMSingle, VMAgent, VMAlert, VMAnomaly, and VLCluster.</comment>

<file context>
@@ -1078,6 +1094,8 @@ func convertVMSingleSpec(values *VMSingleHelmValues) (*vmv1beta1.VMSingleSpec, e
 	spec.PodMetadata = cfg.PodMetadata
 	spec.ServiceSpec = cfg.ServiceSpec
 	spec.Storage = cfg.Storage
+	spec.Volumes = cfg.Volumes
+	spec.VolumeMounts = cfg.VolumeMounts
 
</file context>
Fix with cubic

@AndrewChubatiuk
AndrewChubatiuk merged commit 96bc346 into master Jul 21, 2026
9 checks passed
@AndrewChubatiuk
AndrewChubatiuk deleted the converter-support-extra-volumes branch July 21, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG REPORT (helm-converter) : extraVolumes ans extraVolumeMounts are ignored

2 participants