Use the new snip run and check subcommands#13
Conversation
… list Replace the hardcoded UNPROXYABLE_COMMANDS set with runtime snip check calls to determine whether a command should be wrapped. Commands that pass the check are prefixed with 'snip run --' instead of 'snip'. This delegates shell builtin detection to snip itself and makes the plugin extensible via snip's filter configuration.
|
Thanks for your contribution ! I’ve seen your contribution on snip repo, they haven’t been released yet. I’ll take a closer look at your PR when I have a little more time. At a quick glance, I think we’ll need to check the installed version of snip to prompt users to update it. |
|
That's a good point, didn't think about that. I'll try to add a check for the snip version to preserve the previous behavior when using older version of snip (without the run/check sub-commands) |
I don't think it's important to maintain backward compatibility. I'm more in favor of making sure that people using |
|
Hey folks, any updates on this? |
2 new subcommands were added to snip:
run- safer way to specify the command to be runcheck- check if a command should be run with snip. For example, shell built-ins likecdandexportwould be rejected.This PR:
snip checkfindFirstPipecall - the AST was traversed twice