WIP: Fix bug on multistep - #11
Draft
rintisch wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to solve #8
What I did so far:
UploadResourceViewHelper.getUploadedResource()addFileInFormFrontend()This solves the named bug.
BUT
EmailFinisher fails
To make it working also an adaption in https://github.com/TYPO3/typo3/blob/10cbd42b3f67717e842233ddf8a6cb7a9af6af78/typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php#L152-L155 is needed. It would need to become something like the following:
Therefore it might be the best to add a new finisher like
MultiUploadEmailFinisherwhich contains this adaption. Has the downside that the editor needs to know that this finisher must be used...Failing when form is rerendered
Furthermore does it fail if you go back and forth in a multistep form or if a user violates a validator. I do not know how this work at all. Has someone a hint how EXT:form makes this working when using a single file? Does my solution from above break something?