feat: distinguish dataset-exists vs stale-branch conflicts in proposals - #395
Merged
Merged
Conversation
propose_dataset() gains an override flag. dataset-already-registered stays a hard, non-overridable ProposalConflictError. a branch-exists conflict now raises StaleProposalConflictError instead (carries the open PR url if one exists) -- with override=True, the stale PR is closed and the branch deleted before retrying the proposal once.
|
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`propose_dataset()` gains an `override: bool = False` parameter and a new `StaleProposalConflictError`.
Why: right now any existing `add-dataset/-` branch is treated identically whether the dataset is genuinely already registered or the branch is just a leftover from an earlier, closed/abandoned proposal for the same name+version. That permanently blocks re-proposing a name after a test PR gets closed without its branch being deleted.
What changed:
Benefit: unblocks re-testing/re-proposing a dataset name whose earlier proposal PR was closed without deleting the branch, once the API/UI layers (next PRs in the stack) let a caller confirm and pass `override=True`.