Skip to content

remove comments #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dekelmeirom wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove comments #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
249 changes: 0 additions & 249 deletions sdk/agent.js
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions sdk/config.json
View file
Open in desktop

This file was deleted.

32 changes: 1 addition & 31 deletions sdk/messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ app.use(bodyParser.json());
require('dotenv').config();

var Kafka = require('node-rdkafka');
var config = require('./config.json');

var api_key = process.env.API_KEY;
var knowledge_url = process.env.HUB_URL;
Expand All @@ -22,35 +21,6 @@ class Agent {
this.event = event;
this.conditionMethod = conditionMethod;
this.actionMethod = actionMethod;

// optional - save the message hub credentials in the configuration file

/*
// Config common options
var driver_options = {
//'debug': 'all',
'metadata.broker.list': config.MESSAGE_HUB.kafka_brokers_sasl,
'security.protocol': 'sasl_ssl',
//'ssl.ca.location': '/etc/ssl/certs', // this is the default location in bluemix
'sasl.mechanisms': 'PLAIN',
'sasl.username': config.MESSAGE_HUB.user,
'sasl.password': config.MESSAGE_HUB.password,
'api.version.request': true,
'broker.version.fallback': '0.10.2.1'
};

var consumer_opts = {
'client.id': 'kafka-nodejs-console-sample-consumer',
'group.id': 'kafka-nodejs-console-sample-group'
};

// Add the common options to client
for (var key in driver_options) {
consumer_opts[key] = driver_options[key];
}

this.connection_options = consumer_opts;
*/
}

connect() {
Expand All @@ -68,7 +38,7 @@ class Agent {

return new Promise(function (res, rej) {
request(options, function (err, response, body) {
if (err || response.statusCode !== 200) {
if (err || (response && response.statusCode !== 200)) {
console.log("error:" + body);
rej(body);
} else {
Expand Down
4 changes: 2 additions & 2 deletions sdk/object.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class KnowledgeObject {

return new Promise((resolve, reject) => {
request(options, (err, response, body) => {
if (err || response.statusCode !== 200) {
if (err || (response && response.statusCode !== 200)) {
return reject(body);
}

Expand Down Expand Up @@ -73,7 +73,7 @@ class KnowledgeObject {

return new Promise((resolve, reject) => {
request(options, (err, response, body) => {
if (err || response.statusCode !== 200) {
if (err || (response && response.statusCode !== 200)) {
return reject(body);
}

Expand Down
2 changes: 1 addition & 1 deletion sdk/relation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class KnowledgeRelation {
};
return new Promise((resolve, reject) => {
request(options, (err, response, body) => {
if (err || response.statusCode !== 200) {
if (err || (response && response.statusCode !== 200)) {
console.log(`Error creating relation: ${err} ${body}`);
return reject(body);
}
Expand Down