Improved the defaultRsp to include proper cmdId#117
Open
dhylands wants to merge 2 commits intoWebThingsIO:masterfrom
Open
Improved the defaultRsp to include proper cmdId#117dhylands wants to merge 2 commits intoWebThingsIO:masterfrom
dhylands wants to merge 2 commits intoWebThingsIO:masterfrom
Conversation
mrstegeman
approved these changes
Apr 10, 2019
Contributor
|
Does this still need to be merged, or is it no longer necessary? |
Contributor
Author
|
Yeah - I think I still need to check it out. |
Contributor
|
@dhylands did you ever figure out if this was actually necessary? |
|
I believe that I observed it, but never got around to implementing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not planning on making a new release of the zigbee-adapter for this change, which is why I didn't modify package.json.
But I also didn't want to forget this change.