[codex] Handle OpenAI chat request EOF with failover#3034
Draft
cyglawi-bit wants to merge 1 commit into
Draft
Conversation
Contributor
|
Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement (CLA). To sign, please reply with the following comment:
You only need to sign once — it will be valid for all your future contributions to this project. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
When
httpUpstream.Do(...)failed before an upstream response was available, the service wrote a Chat Completions 502 response directly and returned a plain error. The OpenAI chat handler only switches accounts forUpstreamFailoverError, so transient connection failures such as an upstream EOF could bypass the existing failover loop and stop the client request.Impact
Transient upstream connection failures before any downstream bytes are written can now reuse the existing account failover path. Errors that happen after a response stream has already started are not retried, avoiding duplicate or corrupted client output.
Validation
git diff --checkGOPROXY=https://goproxy.cn,direct GOSUMDB=sum.golang.google.cn go test -tags unit -run 'TestForwardAs(ChatCompletions|RawChatCompletions)_UpstreamRequestEOFTriggersFailoverWithoutWritingResponse' ./internal/service -count=1