Skip to content

fix(audit): an unknown profile named twice by older CLIs no longer blocks a CLI on cli-core 0.717.0 - #686

Merged
leemour merged 1 commit into
mainfrom
fix/shared-difference-unknown-profile
Nov 21, 2026
Merged

leemour merged 1 commit into
mainfrom
fix/shared-difference-unknown-profile

Conversation

@leemour

@leemour leemour commented Nov 21, 2026

Copy link
Copy Markdown
Member

Why

cli-core 0.715 and 0.716 registered account-remove.unknown-profile and account-rename.unknown-profile with one message. cli-core 0.717.0 (#3189) gives account rename profile.unknown, but the CLIs published on 0.715–0.716 still register both. same-error-reason blames every CLI that holds account-remove.unknown-profile, so a CLI already on 0.717.0 cannot pass cli-dev audit --family (wordpress-cli, and cli-template#210's CI) without its own exception.

What

  • src/standards/audit.ts: the pair is a shared difference in FAMILY_SINCE_0_98, review_after 2026-12-10, like ai.address-refused=model.address-refused before it. It applies to CLIs that pass their own --groups too.
  • src/dev/audit.test.ts: a CLI with only the first name releases while an older one still has both; without the entry it blocks.
  • Fragment changes/fix-shared-difference-unknown-profile.md (Fixed).

Testing

src/dev/audit.test.ts 39 pass; typecheck, lint, docs:check pass. A fresh-agent review ran; its finding (the version range) is fixed.

🤖 Generated with Claude Code

…ocks a CLI on cli-core 0.717.0

cli-core 0.715 and 0.716 registered account-remove.unknown-profile and account-rename.unknown-profile with one
message, and the CLIs published on them still do. same-error-reason blamed every CLI holding the first name, so a CLI
already on 0.717.0 (wordpress-cli, the template) could not release without its own exception (FIND-2855). The pair
is now a shared difference with review_after 2026-12-10, like ai.address-refused=model.address-refused before it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@leemour
leemour merged commit 0054327 into main Nov 21, 2026
10 checks passed
@leemour
leemour deleted the fix/shared-difference-unknown-profile branch November 21, 2026 04:26
@leemour leemour mentioned this pull request Nov 21, 2026
leemour added a commit that referenced this pull request Nov 21, 2026
Dates #686 (an unknown profile named twice by older CLIs no longer
blocks `cli-dev audit --family` for a CLI on cli-core 0.717.0) as
0.126.1. Fixed only, so a patch; the fragment is collected into the
section.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant