Repository navigation
fix(audit): an unknown profile named twice by older CLIs no longer blocks a CLI on cli-core 0.717.0 - #686
Merged
Conversation
…ocks a CLI on cli-core 0.717.0 cli-core 0.715 and 0.716 registered account-remove.unknown-profile and account-rename.unknown-profile with one message, and the CLIs published on them still do. same-error-reason blamed every CLI holding the first name, so a CLI already on 0.717.0 (wordpress-cli, the template) could not release without its own exception (FIND-2855). The pair is now a shared difference with review_after 2026-12-10, like ai.address-refused=model.address-refused before it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
leemour
added a commit
that referenced
this pull request
Nov 21, 2026
Dates #686 (an unknown profile named twice by older CLIs no longer blocks `cli-dev audit --family` for a CLI on cli-core 0.717.0) as 0.126.1. Fixed only, so a patch; the fragment is collected into the section. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
cli-core 0.715 and 0.716 registered
account-remove.unknown-profileandaccount-rename.unknown-profilewith one message. cli-core 0.717.0 (#3189) givesaccount renameprofile.unknown, but the CLIs published on 0.715–0.716 still register both.same-error-reasonblames every CLI that holdsaccount-remove.unknown-profile, so a CLI already on 0.717.0 cannot passcli-dev audit --family(wordpress-cli, and cli-template#210's CI) without its own exception.What
src/standards/audit.ts: the pair is a shared difference inFAMILY_SINCE_0_98,review_after2026-12-10, likeai.address-refused=model.address-refusedbefore it. It applies to CLIs that pass their own--groupstoo.src/dev/audit.test.ts: a CLI with only the first name releases while an older one still has both; without the entry it blocks.changes/fix-shared-difference-unknown-profile.md(Fixed).Testing
src/dev/audit.test.ts39 pass; typecheck, lint, docs:check pass. A fresh-agent review ran; its finding (the version range) is fixed.🤖 Generated with Claude Code