Repository navigation
fix(parity): known-broken lists only whatsapp-cli; rows for messages scheduled cancel|edit|send - #3146
Merged
Conversation
…scheduled cancel|edit|send The 0.707.0 release run (44463906253) reported mail-cli, cli-memo, tg-cli, gcal-cli and bitrix24-cli as passing, and cli-template's tests passed. max-cli, drive-cli and zoom-cli are fixed in their own pull requests. whatsapp-cli stays, re-pointed to #3139 with its reason. #3139 added three messages scheduled commands without parity.json rows, so the manifest check failed for max-cli and tg-cli; continue-on-error hid it while both were listed. A known-broken entry now carries a reason, and the error message asks for one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
max-cli#984's own CI runs the parity manifest check against cli-core on npm, which has no messages scheduled rows yet, so it cannot merge before a release carries them. A cli-core release in between would build max-cli's main, which still fails. The entry ends on 2026-11-21. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leemour
added a commit
that referenced
this pull request
Nov 20, 2026
## Task `scripts/parity/known-broken.json` should list only CLIs that are really broken. #3146 kept max-cli there until its parity.json rows reached npm, because max-cli#984 could not pass its own parity check before that. ## What - max-cli#984 is merged on cli-core 0.714.0, with green CI (`parity:check`, tests, smoke, contracts). Its entry is removed. - whatsapp-cli stays (#3139, until 2026-11-26): `WHATSAPP.lacks` does not name `cancelScheduled`, `editScheduled` and `sendScheduled` yet. - Changelog fragment. No release: the next regular one carries it. ## Testing `pnpm docs:check`; this PR's parity builds max-cli main against this checkout. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
scripts/parity/known-broken.jsonshould list only CLIs that are really broken, each with a reason. The 0.707.0 release run (44463906253) shows most of the list passes.What changes
templatejobmessenger.test.tsfails: #3139 addedcancelScheduled,editScheduled,sendScheduledtoCOMMAND_NEEDS, andWHATSAPP.lacksdoes not name them yetAn entry now has a
reasonfield; the scripts read onlyrepoanduntil, so nothing else changes. The error message asks for the reason too.A gap this uncovered:
parity.jsonrows#3139 added
messages scheduled cancel|edit|sendwithoutparity.jsonrows. The manifest check (main (max),main (tg)) failed in the release run, butcontinue-on-errorhid it because both CLIs were listed. Removing them without the rows would make the release gate fail. The rows say: in max and tg, not in wa ("WhatsApp has no scheduled messages");--htmlon edit in tg only, as onmessages edit.docs/dev/STANDARD.mdre-rendered.Testing
commands.jsonartifacts:tg,max,waandwordingpass with the new rows;tgandmaxfailed before them.pnpm vitest run src/parity(53 tests),pnpm docs:check.app-ref.sh). A PR's parity runs no CLI tests; those ran locally in each CLI and run at the next release.Merge freely: max-cli stays listed, and zoom-cli and drive-cli merge on their own green CI. The release after this one should run with
--app-ref fix/parity-core-0707so parity builds max-cli from its fix branch.🤖 Generated with Claude Code