Fix: Bug: Empty space shown for Model field when saved provider no longer exists#552
Fix: Bug: Empty space shown for Model field when saved provider no longer exists#552hbhalodia wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #552 +/- ##
==========================================
Coverage 71.20% 71.20%
Complexity 1150 1150
==========================================
Files 67 67
Lines 5563 5563
==========================================
Hits 3961 3961
Misses 1602 1602
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dkotter
left a comment
There was a problem hiding this comment.
Thanks for the fixing this, tested and works as expected.
The one thing worth discussing is right now this properly hides the Model dropdown in the situation where someone removes a Connector. But when we make the AI request, we still try and use that Connector even though it doesn't exist.
While you could argue that's expected, the fact that we show the Provider dropdown as being set to Default is confusing here.
I wonder if we should output an error message above that dropdown letting the user know their previous chosen provider no longer exists and they need to update that our the feature won't work.
Or maybe add a new option to the dropdown in this scenario that has the previously set provider name and some helper text, like OpenAI - note this provider no longer exists and should be reset
I'd prefer this path |
What?
Closes #551
Why?
How?
Use of AI Tools
AI assistance: Yes
Tool(s): GitHub Copilot, Claude
Model(s): Claude Opus 4.6
Used for: Used for issue creation and PR description, plus review the approach.
Testing Instructions
Screenshots or screencast
Changelog Entry