Skip to content

Global Styles: Group shadow editor rows as items - #81871

Merged
ciampo merged 3 commits into
trunkfrom
codex/fix-shadow-item-group-composition
Aug 20, 2026
Merged

Global Styles: Group shadow editor rows as items#81871
ciampo merged 3 commits into
trunkfrom
codex/fix-shadow-item-group-composition

Conversation

@ciampo

@ciampo ciampo commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

What?

Closes #81861.

Fixes the shadow editor so each shadow row gets one separator.

Why?

ItemGroup styles expect the DOM shape produced by Item: a list-item wrapper around one inner surface. ShadowItem rendered a Dropdown directly, so the separator also targeted its remove button.

How?

Wrap each ShadowItem in a role="listitem" element, leaving the dropdown as the inner surface. This fixes the consumer without changing the generic ItemGroup selector.

Testing Instructions

  1. Open Site Editor > Styles > Shadows.
  2. Add and open a custom shadow, then add a second shadow row.
  3. Hover a row and confirm there is one separator between rows and none across the remove button.

Testing Instructions for Keyboard

Repeat the steps with Tab and Enter. Confirm each remove button receives focus and removes only its row.

Screenshots

Screenshot 2026-08-20 at 14 37 50

Use of AI Tools

Codex was used to analyze the issue, implement the change, and run verification.

@github-actions

Copy link
Copy Markdown

Size Change: -58 B (0%)

Total Size: 7.75 MB

📦 View Changed
Filename Size Change
build/scripts/editor/index.min.js 537 kB +12 B (0%)
build/styles/edit-site/style-rtl.css 21.8 kB -7 B (-0.03%)
build/styles/edit-site/style-rtl.min.css 17.9 kB -8 B (-0.04%)
build/styles/edit-site/style.css 21.8 kB -7 B (-0.03%)
build/styles/edit-site/style.min.css 17.9 kB -8 B (-0.04%)
build/styles/editor/style-rtl.css 32 kB -8 B (-0.03%)
build/styles/editor/style-rtl.min.css 27.3 kB -12 B (-0.04%)
build/styles/editor/style.css 32 kB -9 B (-0.03%)
build/styles/editor/style.min.css 27.3 kB -11 B (-0.04%)

compressed-size-action

@ciampo ciampo self-assigned this Aug 20, 2026
@ciampo ciampo added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended labels Aug 20, 2026
@ciampo
ciampo requested review from a team, Mamaduka and andrewserong August 20, 2026 12:38
@ciampo
ciampo marked this pull request as ready for review August 20, 2026 12:38
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ciampo
ciampo requested a review from juanfra August 20, 2026 12:39

@Mamaduka Mamaduka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ciampo!

@juanfra juanfra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ciampo! LGTM

@ciampo
ciampo merged commit d3f2c50 into trunk Aug 20, 2026
59 of 60 checks passed
@ciampo
ciampo deleted the codex/fix-shadow-item-group-composition branch August 20, 2026 22:14
@github-actions github-actions Bot added this to the Gutenberg 23.9 milestone Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ItemGroup: isSeparated draws one separator per element inside an item

3 participants