Styles Route: Add missing tsconfig references for api-fetch and html-entities - #81990
Closed
t-hamano wants to merge 1 commit into
Closed
Styles Route: Add missing tsconfig references for api-fetch and html-entities#81990t-hamano wants to merge 1 commit into
t-hamano wants to merge 1 commit into
Conversation
…entities #81954 added `@wordpress/api-fetch` and `@wordpress/html-entities` to `routes/styles/package.json` without adding the matching TypeScript project references, which broke `npm run lint:tsconfig` on trunk. Co-Authored-By: Claude <noreply@anthropic.com>
t-hamano
added
[Type] Experimental
t-hamano
marked this pull request as ready for review
August 24, 2026 14:07
t-hamano
removed
the
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
Closing this as a duplicate of #81989 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #81954. Adds the missing
@wordpress/api-fetchand@wordpress/html-entitiesproject references toroutes/styles/tsconfig.json.Why?
#81954 added both packages to
routes/styles/package.jsonbut not to the tsconfig references, sonpm run lint:tsconfigfails on trunk. That step gates the rest of the Static Analysis workflow, so every following step (lint, typecheck, build) is skipped and all matrix jobs are cancelled.This slipped through because of the order in which #81847 and #81954 landed: #81847 brought the route projects under the tsconfig validation, and #81954 was authored before that and merged after, so its CI runs never checked this.
Testing Instructions
npm run lint:tsconfigpasses.Use of AI Tools
Authored with Claude Code: cause analysis of the CI failure and the fix.