FED-3903 React 18 Upgrade Codemod#319
Merged
btr-rmconsole-5[bot] merged 14 commits intomasterfrom Jul 14, 2025
Merged
Conversation
Contributor
Author
|
See preview in sourcegraph batch for more testing of this codemod: https://github.com/Workiva/sourcegraph-batch-changes/pull/840#issuecomment-3050531635 |
greglittlefield-wf
requested changes
Jul 9, 2025
Contributor
greglittlefield-wf
left a comment
There was a problem hiding this comment.
Just some minor comments; this looks great!
greglittlefield-wf
approved these changes
Jul 14, 2025
Contributor
greglittlefield-wf
left a comment
There was a problem hiding this comment.
+10
@Workiva/release-management-p
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This codemod updates react JS paths in html and dart files from the React 17 versions to the React 18 versions following the method of 1:1 updating the react.js paths and then removing the react_dom paths entirely since React 18 has it all in one file.
Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: