This repository was archived by the owner on May 10, 2022. It is now read-only.
fix: prevent session to be actively closed when it gets response from server #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinzuoyan
reviewed
May 23, 2020
src/main/java/com/xiaomi/infra/pegasus/rpc/async/SessionFailureDetector.java
Outdated
Show resolved
Hide resolved
|
|
||
| // Session is marked failure if all the RPCs across | ||
| // `sessionResetTimeWindowMs` are timed out. | ||
| public static final long FAILURE_DETECT_WINDOW_MS = 10 * 1000; // 10s |
Member
There was a problem hiding this comment.
maybe 10s is too short? consider set it to 30s or 60s?
Author
There was a problem hiding this comment.
I keep it as it was in this refactoring. I will consider a larger window if it makes sense.
levy5307
reviewed
Sep 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples SessionFailureDetector from ReplicaSession.
SessionFailureDetector is responsible for client failure detection to PegasusServer. If continuous timeouts across
FAILURE_DETECT_WINDOW_MSoccurred, the session will automatically disconnect.