C++ mangled name support in Kernel #2480
Conversation
python/iron/kernel.py
Outdated
| """ | ||
| self._name = name | ||
|
|
||
| symbol_name = find_mangled_symbol(f"build/{bin_name}", name) |
There was a problem hiding this comment.
I need to figure out how to get the actual .o path here, it's just the name and then it happens to work during linking.
There was a problem hiding this comment.
I think there is a general implicit assumption that the programming_examples/basic/vector_reduce_min/vector_reduce_min.py file is called within the build dir.
There was a problem hiding this comment.
Good call. aiecc.py is called in the build directory which does the linking, but the MLIR generation happens earlier. I currently need the object file earlier, unless I defer mangling until linking (which it would be the preferred approach).
Generating MLIR while in the build directory allows it to work correctly.
ypapadop-amd
force-pushed
the
ypapadop-amd/mangled-name-support
branch
2 times, most recently
from
39e2847 to
eefb7c3
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Maybe this would be better as an MLIR pass? |
No description provided.