[aievec] Add support for arith.subf and vector.broadcast in aievec for aie2p
#2723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwei-xilinx
requested review from
AndraBisca,
fifield,
hunhoffe,
jackl-xilinx,
jgmelber,
jsetoain and
stephenneuendorffer
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for arith.subf and vector.broadcast operations in the aievec dialect for the aie2 and aie2p targets.
Key changes:
- Implements conversion of floating-point subtraction operations to AIEVec intrinsics for both
aie2andaie2ptargets - Adds specialized broadcast scalar conversion for
aie2psupporting 256-bit and 512-bit vectors - Includes comprehensive test coverage for the new conversions
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/Conversion/VectorToAIEVec/test-sub-aie2p.mlir | New test file verifying arith.subf conversion for aie2p with f32 and bf16 types |
| test/Conversion/VectorToAIEVec/test-arith-aie2.mlir | Updated tests for arith.subf conversion on aie2 target |
| test/Conversion/AIEVecToLLVM/test-sub_elem.mlir | New test validating lowering of aievec.sub_elem to LLVM intrinsics |
| test/Conversion/AIEVecToLLVM/test-broadcast_scalar-aie2p.mlir | New test for broadcast scalar conversion on aie2p with various data types |
| lib/Dialect/AIEVec/Transforms/VectorToAIEVecConversions.cpp | Implements patterns for arith.subf conversion and aie2p-specific broadcast scalar handling |
| lib/Conversion/AIEVecToLLVM/AIEVecToLLVM.cpp | Adds LLVM conversion patterns for sub_elem operations and broadcast scalar for both aie2 and aie2p |
| include/aie/Dialect/XLLVM/IR/XLLVMAIE2IntrOps.td | Defines LLVM intrinsic operations for subtraction on aie2 and aie2p |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.