fix(core/vm,core/tracing): correct outdated comments#2291
fix(core/vm,core/tracing): correct outdated comments#2291gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
Conversation
Update stale comment names in the program and tracing packages to match the current APIs.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates stale Go doc comments in VM program utilities and tracing enums so they match the current API names.
Changes:
- Fix
CallCodedoc comment label incore/vm/program. - Fix
Mstoredoc comment label incore/vm/program. - Fix
GasChangeCallContractCreation2doc comment label in tracing hooks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/vm/program/program.go | Aligns method doc comments (CallCode, Mstore) with actual exported API names. |
| core/tracing/hooks.go | Aligns GasChangeCallContractCreation2 constant comment with the actual identifier. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Proposed changes
Update stale comment names in the program and tracing packages to match the current APIs.
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that