Draft
Conversation
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughHomeReducer 리팩토링개요복잡도가 증가하는 Home Reducer를 아키텍처적으로 개선하기 위한 리팩토링입니다. 상태와 액션의 도메인 기반 분할을 통해 코드 구조를 정리합니다. ( 주요 아키텍처 변경상태(State) 구조 재편성
액션(Action) 세분화
상태 변경 및 흐름 개선Reducer 구현 재조직
비동기 작업 및 사이드 이펙트 명시화
뷰 계층 업데이트HomeView 액션 라우팅 변경
상태 접근 패턴 변경
변경 영역
검토 포인트
WalkthroughHomeReducer의 상태와 액션 구조를 평탄화에서 중첩 분할 구조로 리팩토링했습니다. 상태를 Data, UIState, Presentation으로 분리하고, 액션을 View, Internal, Response, Presentation 하위 열거형으로 재구성했으며, 이에 따라 구현과 뷰를 업데이트했습니다. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can generate a title for your PR based on the changes with custom instructions.Set the |
Member
Author
|
@coderabbitai summary |
✅ Actions performedSummary regeneration triggered. |
jihun32
reviewed
Mar 19, 2026
Contributor
jihun32
left a comment
jihun32
left a comment
There was a problem hiding this comment.
맞아! 근데 지금보니까 State랑 Action에 하위 리듀서 state랑 action이 덩그러니 있는데 이것도 Child로 묶으면 어떨까?
as-is
public var proofPhoto: ProofPhotoReducer.State?to-be
public struct ChildState: Equatable {
public var proofPhoto: ProofPhotoReducer.State?
}action도 비슷하게 하면 될 거 같은데 어때?
Comment on lines
+94
to
106
| public var hasCards: Bool { !data.cards.isEmpty } | ||
|
|
||
| public var goalSectionTitle: String { | ||
| let now = CalendarNow() | ||
| let today = TXCalendarDate(year: now.year, month: now.month, day: now.day) | ||
| if calendarDate < today { | ||
| if data.calendarDate < today { | ||
| return "지난 우리 목표" | ||
| } | ||
| if today < calendarDate { | ||
| if today < data.calendarDate { | ||
| return "다음 우리 목표" | ||
| } | ||
| return "오늘 우리 목표" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
📙 작업 내역
💬 추가 설명 or 리뷰 포인트 (선택)