Skip to content

feat: Spatial Conservation Metrics for scib-metrics - #259

Draft
ori-kron-wis wants to merge 20 commits into
mainfrom
Ori-spatial-scores
Draft

feat: Spatial Conservation Metrics for scib-metrics#259
ori-kron-wis wants to merge 20 commits into
mainfrom
Ori-spatial-scores

Conversation

@ori-kron-wis

Copy link
Copy Markdown
Member

No description provided.

@ori-kron-wis ori-kron-wis self-assigned this Mar 10, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aad357858b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/scib_metrics/benchmark/_core.py Outdated
Comment thread src/scib_metrics/metrics/_spatial.py
Comment thread src/scib_metrics/metrics/_spatial.py
Comment thread src/scib_metrics/metrics/_spatial.py Outdated
@codecov

codecov Bot commented Mar 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.79618% with 114 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.05%. Comparing base (0be2f21) to head (2836266).

Files with missing lines Patch % Lines
src/scib_metrics/metrics/_spatial.py 66.78% 96 Missing ⚠️
src/scib_metrics/benchmark/_core.py 89.94% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   90.72%   86.05%   -4.68%     
==========================================
  Files          26       27       +1     
  Lines        1014     1477     +463     
==========================================
+ Hits          920     1271     +351     
- Misses         94      206     +112     
Files with missing lines Coverage Δ
src/scib_metrics/__init__.py 100.00% <ø> (ø)
src/scib_metrics/benchmark/__init__.py 100.00% <100.00%> (ø)
src/scib_metrics/metrics/__init__.py 100.00% <100.00%> (ø)
src/scib_metrics/benchmark/_core.py 93.04% <89.94%> (-2.31%) ⬇️
src/scib_metrics/metrics/_spatial.py 66.78% <66.78%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ori-kron-wis
ori-kron-wis marked this pull request as draft March 12, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant