Fix TypeError when tvdbseason/TVDBid is None in anime-list mappings#600
Open
tsannie wants to merge 1 commit intoZeroQI:masterfrom
Open
Fix TypeError when tvdbseason/TVDBid is None in anime-list mappings#600tsannie wants to merge 1 commit intoZeroQI:masterfrom
tsannie wants to merge 1 commit intoZeroQI:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some entries in
anime-list-master.xml(ScudLee) havetvdbseasonset toNone—notably One Piece (tvdb-81797) which has dozens of AniDB sub-entries. This causes
TypeError: cannot concatenate 'str' and 'NoneType' objectswhen fetching metadata.Changes
TVDBid.isdigit()→(TVDBid or "").isdigit()— guard againstNone's'+tvdbseason+'e'+...→'s'+str(tvdbseason or '1')+'e'+...— fallback to season 1when mapping is absent
's'+defaulttvdbseason→'s'+str(defaulttvdbseason or '1')— same concatenation fixint(season.get("tvdbseason"))→ addedis not Noneguard —int(None)crashesSCUDLEE_FEEDBACK.format()to preventKeyErrorfrom curlybraces in titles