Skip to content

integration: gs ss from integration submits all tip stacks#1257

Open
ed-irl wants to merge 4 commits into
ed-irl/integration-checkout-shortcutfrom
ed-irl/integration-stack-submit
Open

integration: gs ss from integration submits all tip stacks#1257
ed-irl wants to merge 4 commits into
ed-irl/integration-checkout-shortcutfrom
ed-irl/integration-stack-submit

Conversation

@ed-irl

@ed-irl ed-irl commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

integration: gs ss from integration submits all tip stacks

'gs ss' is "submit the current stack", but the integration branch is
not part of any stack — it's the union of multiple. Running 'gs ss'
from there previously crashed with "branch not found in store"
because the lookup against the branch graph fails for untracked
branches.

When the current branch matches the configured integration name,
dispatch into an integration-aware path: collect the full stack
(upstack + downstack, trunk excluded) of each configured tip in
trunk-first topological order, dedup branches shared across tips,
hand the result to SubmitBatch, then push the integration branch
itself with its existing force-with-lease semantics.

This is broader than 'gs integration submit' (which only submits the
downstack of each tip); 'gs ss' is the "submit everything in this
stack" command, and from integration that means upstack too.

integration-stack-submit: Regenerate derived files

@ed-irl

ed-irl commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

@ed-irl ed-irl force-pushed the ed-irl/integration-checkout-shortcut branch from 7dbd7a4 to a28072b Compare June 13, 2026 13:40
@ed-irl ed-irl force-pushed the ed-irl/integration-stack-submit branch from b49c605 to 84bfc7a Compare June 13, 2026 13:40
@ed-irl ed-irl force-pushed the ed-irl/integration-checkout-shortcut branch from a28072b to 781c846 Compare June 15, 2026 09:54
@ed-irl ed-irl force-pushed the ed-irl/integration-stack-submit branch from 84bfc7a to 40efc83 Compare June 15, 2026 09:54
ed-irl and others added 3 commits June 23, 2026 11:43
'gs ss' is "submit the current stack", but the integration branch is
not part of any stack — it's the union of multiple. Running 'gs ss'
from there previously crashed with "branch not found in store"
because the lookup against the branch graph fails for untracked
branches.

When the current branch matches the configured integration name,
dispatch into an integration-aware path: collect the full stack
(upstack + downstack, trunk excluded) of each configured tip in
trunk-first topological order, dedup branches shared across tips,
hand the result to SubmitBatch, then push the integration branch
itself with its existing force-with-lease semantics.

This is broader than 'gs integration submit' (which only submits the
downstack of each tip); 'gs ss' is the "submit everything in this
stack" command, and from integration that means upstack too.
@ed-irl ed-irl force-pushed the ed-irl/integration-checkout-shortcut branch from 81ff834 to 6237432 Compare June 24, 2026 01:33
@ed-irl ed-irl force-pushed the ed-irl/integration-stack-submit branch from f072c95 to 22b8904 Compare June 24, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant