integration: gs ss from integration submits all tip stacks#1257
Open
ed-irl wants to merge 4 commits into
Open
Conversation
This was referenced Jun 12, 2026
Collaborator
Author
This was referenced Jun 12, 2026
Open
7dbd7a4 to
a28072b
Compare
b49c605 to
84bfc7a
Compare
a28072b to
781c846
Compare
84bfc7a to
40efc83
Compare
'gs ss' is "submit the current stack", but the integration branch is not part of any stack — it's the union of multiple. Running 'gs ss' from there previously crashed with "branch not found in store" because the lookup against the branch graph fails for untracked branches. When the current branch matches the configured integration name, dispatch into an integration-aware path: collect the full stack (upstack + downstack, trunk excluded) of each configured tip in trunk-first topological order, dedup branches shared across tips, hand the result to SubmitBatch, then push the integration branch itself with its existing force-with-lease semantics. This is broader than 'gs integration submit' (which only submits the downstack of each tip); 'gs ss' is the "submit everything in this stack" command, and from integration that means upstack too.
81ff834 to
6237432
Compare
f072c95 to
22b8904
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integration: gs ss from integration submits all tip stacks
'gs ss' is "submit the current stack", but the integration branch is
not part of any stack — it's the union of multiple. Running 'gs ss'
from there previously crashed with "branch not found in store"
because the lookup against the branch graph fails for untracked
branches.
When the current branch matches the configured integration name,
dispatch into an integration-aware path: collect the full stack
(upstack + downstack, trunk excluded) of each configured tip in
trunk-first topological order, dedup branches shared across tips,
hand the result to SubmitBatch, then push the integration branch
itself with its existing force-with-lease semantics.
This is broader than 'gs integration submit' (which only submits the
downstack of each tip); 'gs ss' is the "submit everything in this
stack" command, and from integration that means upstack too.
integration-stack-submit: Regenerate derived files