shamhub: Implement ChecksByChange with full rollup + runs + URL seeding#1264
Open
ed-irl wants to merge 1 commit into
Open
shamhub: Implement ChecksByChange with full rollup + runs + URL seeding#1264ed-irl wants to merge 1 commit into
ed-irl wants to merge 1 commit into
Conversation
Collaborator
Author
|
This change is part of the following stack:
Change managed by git-spice. |
This was referenced Jun 13, 2026
e05989b to
cb608dc
Compare
2d1068f to
8c55472
Compare
Implements the per-change checks report for the in-process forge so
script and forge-suite tests can exercise the payload without a real
CI system.
- shamChange grows a ChecksReport pointer, seeded by SetChangeChecks
and read back by ChecksByChange (unseeded reports as none).
- New POST /{owner}/{repo}/change/checks-by-change endpoint mirrors
the comment-counts batch shape, with a nil slot per unknown change.
- 'shamhub set-checks <owner/repo> <pr> <json>' seeds rich payloads
from test scripts.
Lives in checks_report.go; upstream's checks.go (per-check
ChangeChecks) is left untouched.
cb608dc to
f473f97
Compare
8c55472 to
6cf278c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the per-change checks API for the in-process forge so
script tests and forge-suite tests can exercise the new payload
without going to a real CI system.
existing ChecksState. Backward compatible: SetChangeChecksState
still works for tests that only seed a rollup.
full structure; ChecksByChange(owner, repo, ns) reads it back,
treating zero-value ChecksState as ChecksNone (no checks
configured/reported, distinct from passing).
mirrors the comment-counts batch shape. Returns one nil slot
per unknown change so callers can correlate by index.
parses the response back into forge.ChangeChecks.
the new ChecksState value added on the schema branch.
' for seeding rich payloads from .txt scripts.