state: Store staged inline comments#1281
Open
abhinav wants to merge 3 commits into
Open
Conversation
Forge implementations can now list, post, reply to, batch-submit, resolve, and edit inline review comments. GitHub, GitLab, Bitbucket, and ShamHub implement the shared inline-comment interfaces so higher-level comment workflows can depend on one forge boundary instead of forge-specific API calls. Bitbucket and GitLab comment operations use typed gateway methods for comment creation, thread resolution, and merge request discussions. That keeps inline comment support on the same gateway boundary as the rest of the forge integration.
Owner
Author
|
This change is part of the following stack: Change managed by git-spice. |
abhinav
force-pushed
the
branch-comment-forge
branch
from
0719a4f to
c8254f9
Compare
Inline comment operations now carry the thread identifier, line range, and diff side as named forge-domain types. The public inline-comment contract also owns thread resolution because all current inline-comment implementations support it. Inline comment editing is part of the base repository contract because every repository implementation already provides the operation.
The comments CLI needs a local representation for inline comments that have been prepared but not submitted to a forge yet. Staged comments now persist the target path, line range, body, diff side, and optional thread identifier in the spice state database. That gives command code a stable state boundary before it batches the comments into a forge review. Extracted from #1162
abhinav
force-pushed
the
branch-comment-forge
branch
from
c8254f9 to
dabcd6f
Compare
abhinav
force-pushed
the
branch-comment-spice-state
branch
from
82cc3f5 to
7ee17ba
Compare
ed-irl
force-pushed
the
branch-comment-forge
branch
2 times, most recently
from
1d76154 to
5e57d40
Compare
ed-irl
force-pushed
the
branch-comment-forge
branch
from
5e57d40 to
b382179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comments CLI needs a local representation for inline comments that
have been prepared but not submitted to a forge yet.
Staged comments now persist the target path, line range, body,
diff side, and optional thread identifier in the spice state database.
That gives command code a stable state boundary before it batches the
comments into a forge review.
Extracted from #1162