Skip to content

feat: add custom assignment rules evaluation #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joalves merged 22 commits into from
Apr 13, 2026
Merged

feat: add custom assignment rules evaluation #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
b8264e9
feat: add custom assignment rules evaluation
joalves Mar 23, 2026
c42bec4
fix: validate rule.variant is a number and improve test coverage
joalves Mar 23, 2026
5ff93e8
fix: use overridden flag instead of custom for rule-matched assignments
joalves Mar 23, 2026
70d4da1
fix: explicitly set eligible=true for rule-matched assignments
joalves Mar 23, 2026
3af7d97
test: verify all exposure flags for rule-matched assignments
joalves Mar 23, 2026
a97cf5c
fix: invalidate cached assignment when rule evaluation result changes
joalves Mar 23, 2026
bb549ec
fix: prevent rule-cached assignment from satisfying override cache check
joalves Mar 23, 2026
777491c
fix: address PR review findings
joalves Mar 23, 2026
724c1b6
fix: remove optional chaining on getClient() and document flag semantics
joalves Mar 23, 2026
981a8d8
fix: skip rules with invalid variant instead of aborting iteration
joalves Mar 23, 2026
963b0c7
feat: add targetingRule flag to exposure events
joalves Mar 23, 2026
89fb6cc
refactor: rename targetingRule to ruleOverride and address review fee…
joalves Mar 24, 2026
c2b400d
fix: rule-matched assignments should not be participants
joalves Mar 25, 2026
c7843c4
refactor: use environment_id from context payload instead of environm…
joalves Mar 26, 2026
b700dce
refactor: move assignment rules to its own field
calthejuggler Apr 1, 2026
928c896
refactor: remove extra nested ors
calthejuggler Apr 2, 2026
ecc0e1f
refactor: use conditions object and type key
calthejuggler Apr 7, 2026
0bbd5ea
fix: update sdk logic to match collector
calthejuggler Apr 13, 2026
6d67092
fix: coderabbit comments
calthejuggler Apr 13, 2026
e3a1c05
fix: ensure rule variants are bounded to experiment nr_variants
calthejuggler Apr 13, 2026
6d99fea
refactor: extract test helper for experiment overrides
calthejuggler Apr 13, 2026
6f3757f
refactor: extract rule variant computation
calthejuggler Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading